38. Refactoring guided by types
TL;DR (5 lines)
- Types are contracts, not decorations.
- A small form is a better teaching unit than isolated declarations.
- The chapter should connect type names to domain meaning.
- Invalid examples should show broken contracts clearly.
- Type clarity reduces later diagnostic work.
Frequent mistakes
- Using a type by habit instead of by domain meaning.
- Explaining individual fields without explaining the full contract.
- Forgetting that invalid examples should show a broken meaning, not just a weird token.
Prerequisites: book/chapters/37-large-scale-module-conventions.html. See also: book/chapters/37-large-scale-module-conventions.html, book/chapters/27-grammar.html, book/chapters/31-build-errors.html.
Concrete Problem
Readers often learn type names but not what type contracts buy them in a real block.
Red Thread (Single Project)
A tiny reporting example uses integers, strings, and a form to make value contracts visible.
For what
This chapter helps the reader choose types based on meaning, not habit.
Work in this chapter
You will inspect a typed example, identify where each type contract matters, then compare it to an invalid variant.
Coherent example
space demo/types
form Report {
name: string
retries: int
ok: bool
}
proc score(r: Report) -> int {
if not r.ok { give 0 }
give r.retries + 1
}
export *
Complete examples
Each block below is a complete reading unit with its own boundary, data shape, and observable result.
Primary coherent example
This is the compact chapter anchor used by the surrounding explanation.
space demo/types
form Report {
name: string
retries: int
ok: bool
}
proc score(r: Report) -> int {
if not r.ok { give 0 }
give r.retries + 1
}
export *
Typed domain form
This example shows text, number, and boolean contracts in one complete flow.
space examples/types/report
form ReportInput {
title: string
count: int
enabled: bool
}
proc readiness(input: ReportInput) -> int {
if input.title == "" { give 11 }
if input.count < 1 { give 12 }
if not input.enabled { give 13 }
give 0
}
proc main(args: list[string]) -> int {
let input: ReportInput = ReportInput { title: "daily", count: 3, enabled: true }
give readiness(input)
}
export *
Result type contract
This version makes success and rejection visible through a result shape.
space examples/types/result
pick ParseResult {
case Parsed(value: int),
case Rejected(code: int),
}
proc parse_count(raw: int) -> ParseResult {
if raw < 0 { give ParseResult.Rejected(20) }
give ParseResult.Parsed(raw)
}
proc main(args: list[string]) -> int {
let result: ParseResult = parse_count(7)
give 0
}
export *
Immediate work for this chapter
- Use forms and picks to show domain meaning, not isolated type names.
- Prefer constructor syntax already used by Vitte docs.
- Show one mismatch where the type contract catches the error early.
- Keep the first code block complete and aligned with current Vitte docs syntax.
- Keep the invalid block focused on one broken contract only.
- Replace generic prose with one concrete rule visible in the code.
- Keep every example small enough to review from top to bottom.
Chapter override: 38-type-driven-refactoring.html
Dedicated problem
38. Refactoring guided by types needs a concrete production-grade anchor around field meaning, value shape, and compiler-enforced mismatch. The page should keep the examples, diagnostics, and review rules tied to that exact boundary instead of drifting back to generic tutorial prose.
Specific complete examples
38. Refactoring guided by types chapter anchor
The primary example is promoted here as the first chapter-specific production reading unit.
space demo/types
form Report {
name: string
retries: int
ok: bool
}
proc score(r: Report) -> int {
if not r.ok { give 0 }
give r.retries + 1
}
export *
Typed domain form
This example shows text, number, and boolean contracts in one complete flow.
space examples/types/report
form ReportInput {
title: string
count: int
enabled: bool
}
proc readiness(input: ReportInput) -> int {
if input.title == "" { give 11 }
if input.count < 1 { give 12 }
if not input.enabled { give 13 }
give 0
}
proc main(args: list[string]) -> int {
let input: ReportInput = ReportInput { title: "daily", count: 3, enabled: true }
give readiness(input)
}
export *
Result type contract
This version makes success and rejection visible through a result shape.
space examples/types/result
pick ParseResult {
case Parsed(value: int),
case Rejected(code: int),
}
proc parse_count(raw: int) -> ParseResult {
if raw < 0 { give ParseResult.Rejected(20) }
give ParseResult.Parsed(raw)
}
proc main(args: list[string]) -> int {
let result: ParseResult = parse_count(7)
give 0
}
export *
Risks and diagnostics
| Risk | Diagnostic signal | Action |
|---|---|---|
| Boundary drift | The chapter loses sight of field meaning, value shape, and compiler-enforced mismatch. | Restate the boundary beside the first code block and every invalid case. |
| Generic prose | A paragraph would still be true in another chapter. | Replace it with a code-specific rule from this page. |
| Weak diagnostic | The failure does not point back to the chapter contract. | Reduce the invalid case until one failure explains the rule. |
Review checklist
- The first example is complete and aligned with Vitte docs syntax.
- The production section names where this construct belongs in real code.
- The risk table connects each failure to a diagnostic or review action.
- The avoid list rejects broad misuse without adding quiz-like prompts.
Production use
- Use this chapter when a code review needs to preserve field meaning, value shape, and compiler-enforced mismatch.
- Keep examples small enough to copy into fixtures or docs smoke tests.
- Treat the invalid case as regression material for future docs checks.
What to avoid
- Do not add a second topic that hides the chapter's main contract.
- Do not expand examples by adding unrelated subsystems.
- Do not rely on prose when a small Vitte block can show the rule.
Global explanation
The value of the chapter is not the list of types. It is the way each type removes ambiguity from the block: text is text, counters are numeric, flags are boolean, and the compiler can enforce that split.
Invalid case
proc bad_report() -> int {
let name: int = "demo"
give name
}
This invalid case is intentionally small. It exists to isolate the contract failure that the chapter is trying to teach.
Common pitfalls
- Using a type by habit instead of by domain meaning.
- Explaining individual fields without explaining the full contract.
- Forgetting that invalid examples should show a broken meaning, not just a weird token.
Short exercise
Take the example form and add one field whose meaning is obviously not numeric. Choose the type that makes the contract clearest.
Summary in 5 points
- Types are contracts, not decorations.
- A small form is a better teaching unit than isolated declarations.
- The chapter should connect type names to domain meaning.
- Invalid examples should show broken contracts clearly.
- Type clarity reduces later diagnostic work.
See also
Next best action
Extend the coherent example by one small, justified step and keep the same contract visible from input to output.
Chapter deep dive
38. Refactoring guided by types connects type names to domain meaning. The chapter is written for a reader deciding which type makes a contract clearer.
The practical boundary is: field meaning, value shape, and compiler-enforced mismatch. Keep that boundary in view while reading the example, the invalid case, and the exercise.
Role in the learning path
Readers often learn type names but not what type contracts buy them in a real block.
A tiny reporting example uses integers, strings, and a form to make value contracts visible.
This chapter helps the reader choose types based on meaning, not habit.
Profile-specific deep dive
Domain shapes
- `form` should group fields that move together through the program.
- `pick` should represent named outcomes instead of magic integers.
- Aliases should clarify intent rather than hide a primitive type without benefit.
Constructor discipline
- Use `Form { field: value }` so field meaning is visible at the call site.
- Keep field names stable when refactoring internal logic.
- Prefer explicit result variants when the caller must handle several outcomes.
Type diagnostics
- A mismatch between `string`, `int`, and `bool` should point back to domain meaning.
- Return type errors are contract errors, not formatting problems.
- Invalid examples should break one type promise at a time.
Reading the valid example
space demo/types: names the ownership boundary before any behavior appears.form Report {: introduces a data contract that later branches can rely on.name: string: supports the chapter contract without adding hidden behavior.retries: int: supports the chapter contract without adding hidden behavior.ok: bool: supports the chapter contract without adding hidden behavior.}: supports the chapter contract without adding hidden behavior.proc score(r: Report) -> int {: states the callable contract: inputs first, result shape last.if not r.ok { give 0 }: guards a failure or edge case before the nominal result.give r.retries + 1: ends the local path with an explicit result.}: supports the chapter contract without adding hidden behavior.export *: supports the chapter contract without adding hidden behavior.
Lesson from the invalid example
proc bad_report() -> int {: this line helps isolate the failure because it states the callable contract: inputs first, result shape last.let name: int = "demo": this line helps isolate the failure because it keeps an intermediate decision visible for review.give name: this line helps isolate the failure because it ends the local path with an explicit result.}: this line helps isolate the failure because it supports the chapter contract without adding hidden behavior.
Engineering decisions to preserve
- Name the boundary before changing code: Types are contracts, not decorations.
- Keep the smallest example executable: A small form is a better teaching unit than isolated declarations.
- Make the invalid path explain one failure only: The chapter should connect type names to domain meaning.
- Prefer a visible contract over an implied convention: Invalid examples should show broken contracts clearly.
- Leave a review anchor that another maintainer can verify: Type clarity reduces later diagnostic work.
Context-specific review criteria
- The page makes the field meaning, value shape, and compiler-enforced mismatch boundary visible before the first code block.
- The intended reader, a reader deciding which type makes a contract clearer, can follow the valid example through named contracts instead of memorized tokens.
- The invalid example fails for the same reason the prose discusses.
- The exercise extends the same contract instead of introducing an unrelated concept.
- The next chapter can reuse the vocabulary introduced here without redefining it.
- The chapter stays specific enough that its title materially changes the meaning of the page.
- Every warning connects to a concrete code shape.
- The summary leaves one durable engineering rule behind.
Contract matrix
| Concern | Chapter rule | Evidence to keep |
|---|---|---|
| Ownership | Code belongs behind the boundary named by the chapter. | The chapter keeps ownership visible through field meaning, value shape, and compiler-enforced mismatch. |
| Input contract | The procedure receives a shape that is named before branching. | The valid example names the accepted shape before branching. |
| Nominal path | The clean path remains readable without hidden state. | The successful result can be found without reading hidden state. |
| Failure path | The invalid case isolates one failure reason. | The broken example has one main reason to fail. |
| Naming | Names explain the domain rather than only the mechanism. | Names remain tied to the chapter goal. |
| Types | Types remove ambiguity from values and results. | Fields and return values carry domain meaning. |
| Control flow | Branches stay traceable from guard to result. | Guards appear before the result they protect. |
| Module boundary | The public surface stays smaller than implementation detail. | The public surface remains smaller than the implementation detail. |
| Diagnostic value | The failure path points back to the exact contract. | The invalid example points back to the exact contract. |
| Test value | Regression evidence covers one passing path and one failing path. | One passing case and one failing case cover the lesson. |
| Refactor value | Implementation cleanup preserves the result shape. | The result shape stays stable during local cleanup. |
| Publication value | The chapter leaves one concrete engineering rule. | The chapter leaves one concrete engineering rule. |
Rewrite path for this chapter
- Rewrite the opening paragraph so it names field meaning, value shape, and compiler-enforced mismatch before naming syntax.
- Keep the valid example small enough that the full contract fits on screen.
- Move any broad claim back to a specific line in the example.
- Preserve one invalid case that fails for the chapter's main reason.
- Add one sentence explaining why the invalid case is not a random error.
- Make every pitfall actionable by naming the code shape it damages.
- Keep the exercise inside the same domain as the example.
- Avoid introducing a second unrelated project just to show variety.
- Use the summary to restate the chapter rule, not the table of contents.
- Check that the next chapter can build on this vocabulary.
- Remove any sentence that would still be true in every other chapter.
- Keep the last action small, local, and testable.
Diagnostic anchors
- The first inspected line is the one that declares the chapter's main contract.
- The central type, field, procedure, or branch carries the chapter's main idea.
- The invalid example includes a sentence-level explanation of its failure.
- Refactors preserve the detail that would otherwise mislead a future reader.
- The behavior that must stay stable is named before implementation changes begin.
- Vague names are replaced before they become review friction.
- Regression coverage protects the chapter's main contract.
- Implementation details stay out of public API unless the chapter explicitly teaches that surface.
- Beginner-facing diagnostics point to the contract, not to a random syntax detail.
- The next chapter can assume one clearly named concept from this page.
When extending this chapter
- Extend toward a reader deciding which type makes a contract clearer, not toward a broader catalog of features.
- Add a second example only if it sharpens the same contract.
- Prefer a small variant over a new subsystem.
- Keep prose close to code; every abstract claim should point to a visible shape.
- Do not hide a new concept in the exercise.
- If a paragraph explains policy, add the concrete code boundary it protects.
- If a paragraph explains syntax, add the semantic reason the syntax matters.
- If a paragraph explains architecture, identify the owner of each boundary.
- If a paragraph explains failure, keep the failing line close to the explanation.
- Stop expanding when the chapter has one complete, testable lesson.
Failure modes to avoid
- Using a type by habit instead of by domain meaning.
- Explaining individual fields without explaining the full contract.
- Forgetting that invalid examples should show a broken meaning, not just a weird token.
Practice scenario
Start from the coherent example in 38. Refactoring guided by types. Change one identifier, one guard, and one returned value. After each change, write down whether the public contract is still the same contract or a new one.
If the contract changed, update the type or result shape first. If only the implementation changed, keep the external name stable and add one regression note explaining what should not change again.
Before moving on
- You can state the chapter role: connects type names to domain meaning.
- You can point to the main boundary: field meaning, value shape, and compiler-enforced mismatch.
- You can connect the invalid case to the problem statement: Readers often learn type names but not what type contracts buy them in a real block.
- You can perform the exercise: Take the example form and add one field whose meaning is obviously not numeric. Choose the type that makes the contract clearest.